Skip to content

Fix exception types in Texture's init #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2023
Merged

Fix exception types in Texture's init #1790

merged 2 commits into from
May 20, 2023

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented May 20, 2023

Changes

  • Use TypeError on wrong types instead of ValueError
  • Correct unit tests to account for this

How to test

./make.py test or pytest tests/unit as usual

@einarf einarf merged commit 1c2975f into pythonarcade:development May 20, 2023
@pushfoo pushfoo deleted the fix_texture_init_exception_types branch May 20, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pushfoo @einarf