Controversial pyright fixes #1788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvcraven
reviewed
May 19, 2023
pushfoo
requested changes
May 22, 2023
There was a problem hiding this comment.
tl;dr I don't have an opinion on the #type: ignore or other elements but do have some concerns about types used in a few places
- The previous standard was to use
RGBA255despite technically accepting RGB colors - We should probably use a more specific exception type when the media player gives nonsense values
pushfoo
reviewed
May 22, 2023
pushfoo
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the pyright fixes that might involve a bit more discussion and refinement before merging.