Skip to content

Improvements to video players #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 8, 2023
Merged

Conversation

MrWardKKHS
Copy link
Contributor

Various improvements to the two Video Players Views in the experimental module. The ultimate goal here would be to have an easy to use class that can load a video and play it, esp as a cutscene. This PR gets closer even though it still doesn't feel solved.

  • The opencv video player and video player view is exposed to users now,
  • The ability to loop the cv2 player added
  • The default behavior of the cv2 player to resize the window turned off
  • Video added from pexels https://www.pexels.com/license/
  • Typing improvements

Future improvements might be to merge VideoPlayerView and CV2PlayerView as this seems like duplication

@MrWardKKHS MrWardKKHS requested a review from einarf May 18, 2023 22:02
Copy link
Member

@einarf einarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're adding mp4 file to arcade we should also add the extension here so it's included in the wheel / source distribution.
https://github.com/pythonarcade/arcade/blob/development/MANIFEST.in

Copy link
Member

@pushfoo pushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good overall, but there some unresolved questions as well as a few changes which I think would be a good idea.

Copy link
Member

@pushfoo pushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this if einarf & CI are. The MANIFEST.in addition is very good attention to detail. 👍

@einarf einarf merged commit c836a53 into pythonarcade:development Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants