-
Notifications
You must be signed in to change notification settings - Fork 343
Improvements to video players #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're adding mp4 file to arcade we should also add the extension here so it's included in the wheel / source distribution.
https://github.com/pythonarcade/arcade/blob/development/MANIFEST.in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good overall, but there some unresolved questions as well as a few changes which I think would be a good idea.
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this if einarf & CI are. The MANIFEST.in
addition is very good attention to detail. 👍
Various improvements to the two Video Players Views in the experimental module. The ultimate goal here would be to have an easy to use class that can load a video and play it, esp as a cutscene. This PR gets closer even though it still doesn't feel solved.
Future improvements might be to merge VideoPlayerView and CV2PlayerView as this seems like duplication