Skip to content

Run pyright on CI #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 29, 2023
Merged

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented May 6, 2023

More stuff extracted from #1738.

ruff, mypy, and pyright logs appear as 3x separate sections in Github Actions results. I wired it up so that all 3 will always run even if an earlier one fails.

CI runs these tasks by calling make.py. This means any changes to make.py will be kept in sync with CI.

We might remove mypy from both lint and CI in the future, but that is not the purpose of this PR.

@eruvanos
Copy link
Member

eruvanos commented May 9, 2023

I think this is a great opportunity to move to pyright! Thanks for your work so far.

@cspotcode cspotcode marked this pull request as ready for review May 26, 2023 14:43
@eruvanos
Copy link
Member

@pvcraven Are you fine to merge this PR, you are hosting the windows machine, and I don't want to merge code without your explicit approval :)

@cspotcode
Copy link
Collaborator Author

This doesn't change what runs on his machine, right? And it's Ubuntu, not windows, right?

@pushfoo
Copy link
Member

pushfoo commented May 27, 2023

This doesn't change what runs on his machine, right?

From what I see in the PR, yes. I think that's all specified in the self hosted runner yaml.

And it's Ubuntu, not windows, right?

If I remember correctly, the self hosted system is a Windows system with a full GL context on bare metal.

@cspotcode
Copy link
Collaborator Author

@eruvanos
Copy link
Member

From what I see in the PR, yes. I think that's all specified in the self hosted runner yaml.

Ah I see

@cspotcode
Copy link
Collaborator Author

Based on the comments above, this is ready to merge.

Are there any other people who need to review, any other topics to discuss?

@eruvanos eruvanos merged commit 7068d35 into pythonarcade:development May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants