-
Notifications
You must be signed in to change notification settings - Fork 343
Run pyright on CI #1754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pyright on CI #1754
Conversation
I think this is a great opportunity to move to pyright! Thanks for your work so far. |
@pvcraven Are you fine to merge this PR, you are hosting the windows machine, and I don't want to merge code without your explicit approval :) |
This doesn't change what runs on his machine, right? And it's Ubuntu, not windows, right? |
From what I see in the PR, yes. I think that's all specified in the self hosted runner yaml.
If I remember correctly, the self hosted system is a Windows system with a full GL context on bare metal. |
Paul saying it's Ubuntu: https://discord.com/channels/458662222697070613/458662458198982676/1108194849494139032 |
Ah I see |
Based on the comments above, this is ready to merge. Are there any other people who need to review, any other topics to discuss? |
More stuff extracted from #1738.
ruff, mypy, and pyright logs appear as 3x separate sections in Github Actions results. I wired it up so that all 3 will always run even if an earlier one fails.
CI runs these tasks by calling
make.py
. This means any changes to make.py will be kept in sync with CI.We might remove mypy from both
lint
and CI in the future, but that is not the purpose of this PR.