Skip to content

Improve readability & controls of sprite depth example #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 27, 2023
Merged

Improve readability & controls of sprite depth example #1731

merged 6 commits into from
Apr 27, 2023

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Apr 27, 2023 •
edited
Loading

Follow-up to reading #1729 (comment)

Changes

  • Move sprite depth demo to a clearer file name
  • Add a top-level docstring including run instructions per arcade's conventions
  • Move hard-coded values into adjustable constants
  • Add space bar toggle for depth testing
  • Add on-screen instruction / status display using batched text matching other examples
  • Add comments

How to test

python -m arcade.experimental.sprite_depth_cosine

@pushfoo pushfoo mentioned this pull request Apr 27, 2023
Merged
@pushfoo pushfoo changed the title Make experimental sprite depth example more legible Improve readability & controls of sprite depth example Apr 27, 2023
@einarf
Copy link
Member

einarf commented Apr 27, 2023

👍

@einarf einarf merged commit e20d111 into pythonarcade:development Apr 27, 2023
@pushfoo pushfoo deleted the touch_up_sprite_depth_example branch May 7, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pushfoo @einarf