Skip to content

Port documentation makefile to .py #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

cspotcode
Copy link
Collaborator

This will need to be rebased after #1710, since it branches off of #1710. Or we can merge this, bring in both PRs at once.

@pushfoo
Copy link
Member

pushfoo commented Apr 24, 2023

This works as-is on my system (Linux).

I think someone other than the contributors should give feedback on the following:

  1. Are the changes to the variable names at the top ok (s/PAPER/PAPER_SIZE/)?
  2. Should we still provide a stub makefile for backward compatibility with programmer habits / brevity?

@Cleptomania
Copy link
Member

Cleptomania commented Apr 24, 2023

I think providing a Makefile in addition to this is going to cause problems. It just adds something else to maintain and creates a divergence in how Arcade is developed. Having everyone using the same process is much simpler.

@cspotcode
Copy link
Collaborator Author

cspotcode commented Apr 24, 2023

As I imagine it, the stub Makefile would be no more than:

.PHONY html
html:
    python ./make.py html
# repeat...

It would be emitted by make.py at startup, but also committed to git, so would be kept in sync automatically.

@cspotcode cspotcode force-pushed the doc-makefile-to-py branch from 27d6cb4 to 4469731 Compare April 24, 2023 14:37
@Cleptomania Cleptomania merged commit b111f41 into pythonarcade:development Apr 24, 2023
@cspotcode cspotcode deleted the doc-makefile-to-py branch August 5, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants