Fix broken early exit in BasicSprite.color setter #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

einarf merged 1 commit into pythonarcade:development from pushfoo:fix_sprite_color_comparison

Mar 19, 2023

Member

pushfoo commented Mar 19, 2023 •

edited

Loading

tl;dr this PR fixes a missing index which makes early exit never happen

self._color is a 4-length tuple
color[0] is expected to be an int
Early exit will never happen because a 4-length tuple to an int will always be false

Discovered while working on #1639


          Fix always-unequal expression in BasicSprite.color setter

b465d3f

pushfoo marked this pull request as ready for review

March 19, 2023 09:31

einarf merged commit 6382be2 into pythonarcade:development

pushfoo deleted the fix_sprite_color_comparison branch

March 19, 2023 09:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet