Skip to content

Improve and fix docs of GUI system #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Improve and fix docs of GUI system #1480

wants to merge 5 commits into from

Conversation

eschan145
Copy link
Contributor

No description provided.

Fixed some documentation and made it neater.

- Maximum character width: 80 chars
- Capitalize comments
- Replace "min" with "minimum"
- Add RST formatting to code blocks and sections
- Add newlines where they are needed

I am not that familiar with ReStructuredText. Double check that the multiline parameter docs and the list docs display correctly.
@eschan145
Copy link
Contributor Author

I'll add some more commits soon; don't merge immediately.

@pvcraven
Copy link
Member

Just checking, you can see what the auto-checks are complaining about?

@eschan145
Copy link
Contributor Author

@pvcraven there might be some multiline code stuff that messed it up.

If we had a line of code like:

this_line_of_code_is_very_very_very_long_and_needs_to_be_trimmed_down.x += a_random_variable.x * 2 + a_random_number()

Then I'm not sure how to wrap it to eighty characters. For now I have only used the blackslash character \, but I'm not sure if it's the right way... It's the same with the docs for parameters. Sometimes they exceed 120 characters, and it's really unreadable.

@eruvanos eruvanos added gui Related to arcade GUI (sub module arcade.gui) documentation labels Jan 29, 2023
@pvcraven
Copy link
Member

You can see what it complains about here:
https://github.com/pythonarcade/arcade/actions/runs/4029149776/jobs/6926745746

Run flake8 on your code base to see the issues locally.

@einarf
Copy link
Member

einarf commented Mar 5, 2023

@eruvanos Is this PR salvagable?

@eruvanos
Copy link
Member

eruvanos commented Mar 6, 2023

Yes, we only have to fix the format for failing pep8.
Then we could merge it, or merge it and fix it afterwards.

@pushfoo
Copy link
Member

pushfoo commented Mar 22, 2023

In addition to the CI failures, many of the changes in this PR break links to classes and break PEP-257:

Multi-line docstrings consist of a summary line just like a one-line docstring, followed by a blank line, followed by a more elaborate description. The summary line may be used by automatic indexing tools; it is important that it fits on one line and is separated from the rest of the docstring by a blank line.

Given the original poster (@eschan145) has not responded for a long time, should this PR be considered abandoned and ok to fork / update?

eruvanos added a commit that referenced this pull request Apr 2, 2023
eruvanos added a commit that referenced this pull request Apr 2, 2023
@eruvanos
Copy link
Member

eruvanos commented Apr 2, 2023

Merged as #1670

@eruvanos eruvanos closed this Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation gui Related to arcade GUI (sub module arcade.gui)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants