Runtime-checkable protocol tests: Use @runtime_checkable, not @runtime#134
Merged
JelleZijlstra merged 1 commit intopython:mainfrom Apr 10, 2023
Merged
Conversation
carljm
approved these changes
Apr 10, 2023
This was referenced May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original name for this decorator was
@runtime, and so that's the name that's currently used in most of the tests for this decorator intyping_extensions. However, the name was changed to@runtime_checkablebefore the decorator was added to thetypingmodule, and so the old@runtimename doesn't appear anywhere in the docs for the typing module. The@runtimename exists intyping_extensionsonly for backwards compatibility.Let's change the usages in our test suite to use the more modern name, so that it's less confusing and more consistent with
typing.