Track optional TypdeDict keys #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
TypedDict-runtime
branch
from
e463f4b to
4127963
Compare
ilevkivskyi
approved these changes
Nov 24, 2019
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks! Generally looks good, it looks like you need to update some tests with @skipIf/@skipUnless. Also probably it would make sense to switch .travis.yaml from 3.8-dev to 3.8 + 3.9-dev.
Zac-HD
force-pushed
the
TypedDict-runtime
branch
from
4127963 to
0db8070
Compare
Zac-HD
force-pushed
the
TypedDict-runtime
branch
from
2cc280e to
a025736
Compare
Contributor
Author
|
Looks like Travis doesn't have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of python/cpython#17214 (BPO-38834) for @ilevkivskyi 😄