Conformance tests: Fix automated scoring for dataclasses_usage.toml #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plus pytype changes The spec doesn't explicitly mention this case. Since it produces a runtime error, it is reasonable for type checkers to error on it, but it should not be required. For pytype, mark a few errors as optionally appearing on a different line. Also, change "x ** 2" to "x * x"; pytype infers "x ** 2" as being of type "float | int" for whatever reason.
25 tasks
erictraut
approved these changes
Apr 6, 2024
JelleZijlstra
added a commit
to JelleZijlstra/typing
that referenced
this pull request
Apr 11, 2024
…ython#1684) Conformance tests: Mark error for unannotated "field()" as optional, plus pytype changes The spec doesn't explicitly mention this case. Since it produces a runtime error, it is reasonable for type checkers to error on it, but it should not be required. For pytype, mark a few errors as optionally appearing on a different line. Also, change "x ** 2" to "x * x"; pytype infers "x ** 2" as being of type "float | int" for whatever reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark error for unannotated field() as optional. The spec doesn't explicitly mention this case. Since it produces a runtime error, it is reasonable for type checkers to error on it, but it should not be required.
For pytype, mark a few errors as optionally appearing on a different line.
Also, change "x ** 2" to "x * x"; pytype infers "x ** 2" as being of type "float | int"
for whatever reason.