Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PyInstaller stubs for all documented modules & packages #8702
Added PyInstaller stubs for all documented modules & packages #8702
Changes from 12 commits
3b218bb
2e1546b
a0b204a
3801205
dd58adc
e445bea
28cee78
925152b
9e54a30
7278859
e35ee77
69e18c5
927419e
7019f09
202d857
082ddf2
d05c59c
307e049
0e9f838
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about why pyright isn't emitting an error here. There's no entry in the
pyrightconfig.stricter.json
exclude-list, so it should be erroring for any parameters that don't have a type annotation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a guess:
pyrightconfig.stricter.json
has"typeCheckingMode": "basic"
and doesn't configure
reportMissingParameterType
. The default value for that setting beingNone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea -- anyway, it's not your fault, and we certainly don't have a requirement that all parameters need to be annotated when first adding stubs :)
I'll look into it and try to work it out...