Remove duplicate definitions, step 1 #8483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
changed the title
This comment has been minimized.
This comment has been minimized.
…shed into remove-duplicates1
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Aug 4, 2022
sobolevn
commented
Aug 4, 2022
| def __le__(self, other: TimerHandle) -> bool: ... | ||
| def __gt__(self, other: TimerHandle) -> bool: ... | ||
| def __ge__(self, other: TimerHandle) -> bool: ... | ||
| def __eq__(self, other: object) -> bool: ... |
There was a problem hiding this comment.
After revisiting some implementation details, this is incorrect and needs to be reverted. Mypy treats == with strict_equliaty differently with __eq__ defined in class and in object super-class.
So, I will revert all __eq__ changes.
sobolevn
added a commit
to sobolevn/typeshed
that referenced
this pull request
Aug 4, 2022
Merged
This was referenced Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed all duplicates found by python/mypy#13321 from modules starting with
_anda. There are lots of other modules to work on.But, I want to split this in parts (I am not able to do it in one PR, too much!).
Except for
__hash__method, which has its own PR: #8465