Move Match and Pattern to re.pyi; move ContextManager protocols to contextlib.pyi#8447
Merged
srittau merged 1 commit intopython:masterfrom Jul 31, 2022
Merged
Move Match and Pattern to re.pyi; move ContextManager protocols to contextlib.pyi#8447srittau merged 1 commit intopython:masterfrom
Match and Pattern to re.pyi; move ContextManager protocols to contextlib.pyi#8447srittau merged 1 commit intopython:masterfrom
Conversation
…ls to `contextlib.pyi`
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pyinstrument (https://github.com/joerick/pyinstrument)
- pyinstrument/vendor/decorator.py:279: error: Module "contextlib" has no attribute "GeneratorContextManager"; maybe "_GeneratorContextManager", "_AsyncGeneratorContextManager", or "ContextManager"?
+ pyinstrument/vendor/decorator.py:279: error: Module "contextlib" has no attribute "GeneratorContextManager"; maybe "_GeneratorContextManager", "_AsyncGeneratorContextManager", or "AbstractContextManager"?
paroxython (https://github.com/laowantong/paroxython)
- paroxython/map_taxonomy.py:178: error: Argument 1 to "append" of "list" has incompatible type "Tuple[regex._regex.Pattern[str], TaxonPattern]"; expected "Tuple[typing.Pattern[Any], TaxonPattern]"
+ paroxython/map_taxonomy.py:178: error: Argument 1 to "append" of "list" has incompatible type "Tuple[regex._regex.Pattern[str], TaxonPattern]"; expected "Tuple[re.Pattern[Any], TaxonPattern]"
prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/client.py:125: error: Argument 1 to "asynccontextmanager" has incompatible type "Callable[[Any], ContextManager[None]]"; expected "Callable[[Any], AsyncIterator[<nothing>]]"
+ src/prefect/client.py:125: error: Argument 1 to "asynccontextmanager" has incompatible type "Callable[[Any], AbstractContextManager[None]]"; expected "Callable[[Any], AsyncIterator[<nothing>]]"
- src/prefect/context.py:465: error: Incompatible types in assignment (expression has type "None", variable has type "ContextManager[SettingsContext]")
+ src/prefect/context.py:465: error: Incompatible types in assignment (expression has type "None", variable has type "AbstractContextManager[SettingsContext]")
- src/prefect/context.py:519: error: Incompatible types in assignment (expression has type "None", variable has type "ContextManager[PrefectObjectRegistry]")
+ src/prefect/context.py:519: error: Incompatible types in assignment (expression has type "None", variable has type "AbstractContextManager[PrefectObjectRegistry]")
|
srittau
approved these changes
Jul 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.