Skip to content

Remove mypy error codes from the test_cases directory #8083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions test_cases/stdlib/builtins/test_pow.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,12 @@
assert_type((-95) ** 8.42, Any)

# All of the following cases should fail a type-checker.
#
# mypy/pyright will emit errors if any of them do not fail:
# - We use --warn-unused-ignores for mypy when checking this subdirectory;
# - For pyright, we have reportUnnecessaryTypeIgnoreComment=true at the top of this file
pow(1.9, 4, 6) # type: ignore[misc]
pow(4, 7, 4.32) # type: ignore[misc]
pow(6.2, 5.9, 73) # type: ignore[misc]
pow(complex(6), 6.2, 7) # type: ignore[misc]
pow(Fraction(), 5, 8) # type: ignore[call-overload]
Decimal("8.7") ** 3.14 # type: ignore[operator]
pow(1.9, 4, 6) # type: ignore
pow(4, 7, 4.32) # type: ignore
pow(6.2, 5.9, 73) # type: ignore
pow(complex(6), 6.2, 7) # type: ignore
pow(Fraction(), 5, 8) # type: ignore
Decimal("8.7") ** 3.14 # type: ignore

# TODO: This fails at runtime, but currently passes mypy and pyright:
pow(Decimal("8.5"), 3.21)
12 changes: 6 additions & 6 deletions test_cases/stdlib/builtins/test_sum.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ def __radd__(self, other: Any) -> "Baz":
sum([2.5, 5.8], 5) # mypy: `float`; pyright: `float | int`

# These all fail at runtime
sum("abcde") # type: ignore[arg-type]
sum([["foo"], ["bar"]]) # type: ignore[list-item]
sum([("foo",), ("bar", "baz")]) # type: ignore[list-item]
sum([Foo(), Foo()]) # type: ignore[list-item]
sum([Bar(), Bar()], Bar()) # type: ignore[call-overload]
sum([Bar(), Bar()]) # type: ignore[list-item]
sum("abcde") # type: ignore
sum([["foo"], ["bar"]]) # type: ignore
sum([("foo",), ("bar", "baz")]) # type: ignore
sum([Foo(), Foo()]) # type: ignore
sum([Bar(), Bar()], Bar()) # type: ignore
sum([Bar(), Bar()]) # type: ignore

# TODO: these pass pyright with the current stubs, but mypy erroneously emits an error:
# sum([3, Fraction(7, 22), complex(8, 0), 9.83])
Expand Down
2 changes: 1 addition & 1 deletion test_cases/stdlib/test_codecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
assert_type(codecs.decode(b"x", "unicode-escape"), str)

assert_type(codecs.decode(b"x", "utf-8"), str)
codecs.decode("x", "utf-8") # type: ignore[call-overload]
codecs.decode("x", "utf-8") # type: ignore

assert_type(codecs.decode("ab", "hex"), bytes)
assert_type(codecs.decode(b"ab", "hex"), bytes)
12 changes: 6 additions & 6 deletions test_cases/stdlib/test_unittest.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@
case.assertAlmostEqual(2.4, 2.41, delta=0.02)
case.assertAlmostEqual(2.4, 2.41, None, "foo", 0.02)

case.assertAlmostEqual(2.4, 2.41, places=9, delta=0.02) # type: ignore[call-overload]
case.assertAlmostEqual("foo", "bar") # type: ignore[call-overload]
case.assertAlmostEqual(datetime(1999, 1, 2), datetime(1999, 1, 2, microsecond=1)) # type: ignore[arg-type]
case.assertAlmostEqual(2.4, 2.41, places=9, delta=0.02) # type: ignore
case.assertAlmostEqual("foo", "bar") # type: ignore
case.assertAlmostEqual(datetime(1999, 1, 2), datetime(1999, 1, 2, microsecond=1)) # type: ignore

case.assertNotAlmostEqual(Fraction(49, 50), Fraction(48, 50))
case.assertNotAlmostEqual(datetime(1999, 1, 2), datetime(1999, 1, 2, microsecond=1), delta=timedelta(hours=1))
case.assertNotAlmostEqual(datetime(1999, 1, 2), datetime(1999, 1, 2, microsecond=1), None, "foo", timedelta(hours=1))

case.assertNotAlmostEqual(2.4, 2.41, places=9, delta=0.02) # type: ignore[call-overload]
case.assertNotAlmostEqual("foo", "bar") # type: ignore[call-overload]
case.assertNotAlmostEqual(datetime(1999, 1, 2), datetime(1999, 1, 2, microsecond=1)) # type: ignore[arg-type]
case.assertNotAlmostEqual(2.4, 2.41, places=9, delta=0.02) # type: ignore
case.assertNotAlmostEqual("foo", "bar") # type: ignore
case.assertNotAlmostEqual(datetime(1999, 1, 2), datetime(1999, 1, 2, microsecond=1)) # type: ignore
7 changes: 4 additions & 3 deletions tests/mypy_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ def get_mypy_flags(
custom_typeshed: bool = False,
strict: bool = False,
test_suite_run: bool = False,
enforce_error_codes: bool = True,
) -> list[str]:
flags = [
"--python-version",
Expand All @@ -240,8 +241,6 @@ def get_mypy_flags(
"--warn-incomplete-stub",
"--show-error-codes",
"--no-error-summary",
"--enable-error-code",
"ignore-without-code",
"--strict-equality",
]
if temp_name is not None:
Expand All @@ -260,6 +259,8 @@ def get_mypy_flags(
flags.extend(["--exclude", "tests/pytype_test.py"])
else:
flags.append("--no-site-packages")
if enforce_error_codes:
flags.extend(["--enable-error-code", "ignore-without-code"])
return flags


Expand Down Expand Up @@ -406,7 +407,7 @@ def test_the_test_scripts(code: int, major: int, minor: int, args: argparse.Name
def test_the_test_cases(code: int, major: int, minor: int, args: argparse.Namespace) -> TestResults:
test_case_files = list(map(str, Path("test_cases").rglob("*.py")))
num_test_case_files = len(test_case_files)
flags = get_mypy_flags(args, major, minor, None, strict=True, custom_typeshed=True)
flags = get_mypy_flags(args, major, minor, None, strict=True, custom_typeshed=True, enforce_error_codes=False)
print(f"Running mypy on the test_cases directory ({num_test_case_files} files)...")
print("Running mypy " + " ".join(flags))
if args.dry_run:
Expand Down