Skip to content

Fix various __all__-related errors and omissions #8031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 7, 2022

Conversation

AlexWaygood
Copy link
Member

These were all discovered using the stubtest patch I have over at python/mypy#12214

@AlexWaygood
Copy link
Member Author

Ah, it looks like pytype doesn't have ParamSpecArgs or ParamSpecKwargs in its copy of typing.pyi.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these! I will get around to reviewing the stubtest PR (although you may want to get some version of it to run on third party stubs)

@AlexWaygood
Copy link
Member Author

although you may want to get some version of it to run on third party stubs

Yah, I'll have a go at doing that tomorrow with the same method I employed here :)

(Namely, what I did here was to edit the stubtest workflow on my fork of typeshed so that it pointed towards the branch on my mypy fork with the stubtest patch. Then I manually ran the CI from my local fork.)

@AlexWaygood AlexWaygood merged commit e7a5b7a into python:master Jun 7, 2022
@AlexWaygood AlexWaygood deleted the stubtestall branch June 7, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants