pygments: Correct Formatter generics #7435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-my-profile
force-pushed
the
fix-pygments
branch
4 times, most recently
from
ab779a2
to
33c6ba8
Compare
933fec0 made pygments.formatter.Formatter generic to improve the type-safety of pygments.format() and pygments.highlight(). The actual pygments.formatter.Formatter however is not generic, meaning that pygments.formatter.Formatter[str] should not type check (since it leads to a runtime type error). Furthermore the pygments ImageFormatter always expects BinaryIO, no matter which constructor arguments are passed. This commit addresses both problems.
not-my-profile
force-pushed
the
fix-pygments
branch
from
33c6ba8
to
d24f07c
Compare
Akuli
reviewed
Mar 4, 2022
|
Ok I am confused the current I am closing this for now, so that we can discuss this properly in #7436. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
933fec0 made
pygments.formatter.Formatter generic to improve the type-safety
of pygments.format() and pygments.highlight().
The actual pygments.formatter.Formatter however is not generic,
meaning that pygments.formatter.Formatter[str] should not type check
(since it leads to a runtime type error).
Furthermore the pygments ImageFormatter always expects BinaryIO,
no matter which constructor arguments are passed.
This commit addresses both problems.