-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add (Base)ExceptionGroup #6655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add (Base)ExceptionGroup #6655
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question below, but LGTM.
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
A couple questions:
I'm happy to submit a follow-up PR to fix these. |
@agronholm good catch about the I think I used |
The PEP doesn't really define the |
Yes, the summary is that you're right on both counts :) Feel free to submit a PR! |
Done: #6895 |
I noticed another issue: |
Fixes #6632