Update importlib to reflect recent changes
#6557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peshed into improve-importlib
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
reviewed
Dec 10, 2021
| @@ -25,6 +25,7 @@ enum.Enum._generate_next_value_ | |||
| fractions.Fraction.__new__ # overload is too complicated for stubtest to resolve | |||
| hmac.HMAC.__init__ | |||
| importlib.metadata # Added in 3.8 | |||
| importlib.metadata._meta # Added in 3.10 | |||
There was a problem hiding this comment.
I think we can remove these allowlist overrides, once mypy 0.920 gets released, as it includes python/mypy#11069.
srittau
approved these changes
Dec 10, 2021
This was referenced Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
importlibAPI has evolved quite rapidly over the past 3 versions of Python.The big change here is creating the subdirectory
importlib.metadata(added to CPython in Python 3.10), and moving the code that was inimportlib.metadata.pyiintoimportlib.metadata.__init__.pyi