Skip to content

Conversation

@srittau
Copy link
Collaborator

@srittau srittau commented May 15, 2021

@Akuli I think these are the permission we originally had.

Possibly, maybe closes #5459

@srittau srittau requested a review from Akuli May 15, 2021 12:26
@srittau
Copy link
Collaborator Author

srittau commented May 15, 2021

If this doesn't work, we should just try permissions: write-all for this job.

Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it would need a write permission on this repository and not on my fork, but sure, let's try that.

@srittau
Copy link
Collaborator Author

srittau commented May 15, 2021

I don't know why it would need a write permission on this repository and not on my fork, but sure, let's try that.

I don't know either, but I seem to remember that his is what you figured out worked initially. Although I am about to give up about it (see above).

@srittau srittau merged commit 056981b into python:master May 15, 2021
@srittau srittau deleted the fix-primer branch May 15, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mypy_primer commenting is still broken

2 participants