Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FrozenSet to the typing stub files #474

Merged
merged 1 commit into from
Aug 14, 2016
Merged

Conversation

Vgr255
Copy link
Contributor

@Vgr255 Vgr255 commented Aug 14, 2016

Followup from python/typing#261

Now, mypy sees that FrozenSet is in the module, but it complains that it's an invalid type. I'm probably overlooking something simple, I guess.

@gvanrossum
Copy link
Member

Oh, TypeAlias() only works for types that have hard-coded support in mypy. But I think you can make it derive from AbstractSet and you probably won't have to add anything else.

@Vgr255
Copy link
Contributor Author

Vgr255 commented Aug 14, 2016

Aah, fair enough. I still have a bit to learn about mypy.

@Vgr255
Copy link
Contributor Author

Vgr255 commented Aug 14, 2016

Force-pushed new commit; mypy effectively detects it. Cheers!

@gvanrossum gvanrossum merged commit 0989cb1 into python:master Aug 14, 2016
@gvanrossum
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants