Move tornado to 2and3 #3780
Merged
Move tornado to 2and3 #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Feb 26, 2020
| from tornado import httputil | ||
|
|
||
| MIN_SUPPORTED_SIGNED_VALUE_VERSION: Any | ||
| MAX_SUPPORTED_SIGNED_VALUE_VERSION: Any | ||
| DEFAULT_SIGNED_VALUE_VERSION: Any | ||
| DEFAULT_SIGNED_VALUE_MIN_VERSION: Any | ||
|
|
||
| if sys.version_info[:2] >= (3, 5): | ||
| from typing import Awaitable | ||
| _MethodType = Callable[..., Optional[Awaitable[None]]] |
There was a problem hiding this comment.
Why does the return type have None in Python 3.5+ but is Any in earlier versions? Is it because we can't represent the type in prior Python versions?
There was a problem hiding this comment.
I am not 100% sure but IIUC the API logic changed at some point. At least on Python 2 these methods used to return something in subclasses (like self.render()), while on Python 3 they act via side effects only (like self.write()).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also uses a trick to avoid
Incompatible with supertypeerrors forget()etc. that used to have signature likedef get(*args, **kwars): ...(that btw is used in tornado itself, see https://github.com/tornadoweb/tornado/blob/master/tornado/web.py#L266).