Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: mark keyword-only args, remove deprecated arg #3756

Merged
merged 3 commits into from
Feb 22, 2020

Conversation

hauntsaninja
Copy link
Collaborator

No description provided.

hauntsaninja added 3 commits February 20, 2020 23:31
Technically only true for Python 3.6+, but I didn't feel like copying
over the whole file just for Python 3.5. Let me know and I can.
This has been ignored and deprecated since 3.1 and will be removed in 3.9
It no longer even shows up in inspect.signature (in 3.8 it emits the
deprecation warning based on kwargs)
@hauntsaninja
Copy link
Collaborator Author

json: mark keyword-only args:
Technically only true for Python 3.6+, but I didn't feel like copying
over the whole file just for Python 3.5. Let me know and I can.

json: remove encoding from loads:
This has been ignored and deprecated since 3.1 and will be removed in 3.9
It no longer even shows up in inspect.signature (in 3.8 it emits the
deprecation warning based on kwargs)

@hauntsaninja
Copy link
Collaborator Author

python/mypy#8423 for CI failure

@JelleZijlstra JelleZijlstra merged commit 003fc6f into python:master Feb 22, 2020
@hauntsaninja hauntsaninja deleted the json branch February 22, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants