Skip to content

Conversation

@jonathanslenders
Copy link
Contributor

Fixes #1467.

@srittau
Copy link
Collaborator

srittau commented May 27, 2019

I assume that mmap actually implements the buffer protocol, but I didn't check. We should preferably fix python/typing#593.

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, even if typing.Buffer is a better solution

@JelleZijlstra
Copy link
Member

mypy is unhappy with this because of various incompatible method overrides. I suppose we either have to # type: ignore most of the class or implement typing.Buffer.

@srittau
Copy link
Collaborator

srittau commented Oct 8, 2019

I am going to close this for now. Please reopen, if you want to try fixing the build errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mypy does not accept mmap object in re.match

3 participants