Add annotation for Future._callbacks #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
reviewed
May 7, 2019
- Added support for python 3.7 annotation for `_callbacks` - Changed `Sequence` to `List`
mvismonte
force-pushed
the
typeshed-asyncio-future-callbacks
branch
from
60259d6 to
94a0d22
Compare
|
@srittau @JelleZijlstra I addressed the feedback. I also plan on making |
JelleZijlstra
approved these changes
May 7, 2019
srittau
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future._callbacksis suppose to be a List ofCallable[[_S], Any]according to:
https://github.com/python/cpython/blob/3.6/Lib/asyncio/futures.py#L159
add_done_callbackon this class takes in the function that's appendedinto
_callbacksTested by running against IG's codebase and confirming that
pyrenowacknowledges
Future._callbacksNote: I noticed that
_callbacksandadd_done_callbacktake slightlydifferent arguments for python 3.7. I can update the signature to be
compatible (it also takes in a context env) in a future PR.