Add TypedDict to typing_extensions #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def viewvalues(self) -> ValuesView[object]: ... | ||
| def __delitem__(self, k: NoReturn) -> None: ... | ||
|
|
||
| def TypedDict(typename: str, fields: Dict[str, Type[_T]], total: bool = ...) -> Type[dict]: ... |
There was a problem hiding this comment.
Shouldn't it return Type[_TypedDict]?
There was a problem hiding this comment.
Hm, I would say so, but maybe there is a reason why this is bad. @JukkaL, is this intentional?
There was a problem hiding this comment.
We just discussed this and decided it should be just object, because it is a magic special object like TypeVar.
JelleZijlstra
approved these changes
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is a PEP for
TypedDict(PEP 589), it is being added totyping_extension, see python/typing#628. This PR essentially copies the definition frommypy_extensions.Corresponding mypy PR python/mypy#6744 can be merged independently of this PR.