RotatingFileHandler has a terminator property #1952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python3 `RotatingFileHandler` is a subclass of `BaseRotatingHandler` which is a subclass of `FileHandler` which is a subclass of `StreamHandler` which as a `terminator` property but I'm getting a `"RotatingFileHandler" has no attribute "terminator"` error on my code.
stdlib/2and3/logging/handlers.pyi
Outdated
| @@ -40,6 +41,7 @@ if sys.version_info >= (3,): | |||
|
|
|||
| if sys.version_info >= (3,): | |||
| class RotatingFileHandler(BaseRotatingHandler): | |||
| terminator = ... # type: str | |||
There was a problem hiding this comment.
This is redundant with BaseRotatingHandler, is it not?
There was a problem hiding this comment.
Ping, could you remove this?
There was a problem hiding this comment.
Done, sorry for the delay.
JelleZijlstra
requested changes
Mar 17, 2018
stdlib/2and3/logging/handlers.pyi
Outdated
| @@ -40,6 +41,7 @@ if sys.version_info >= (3,): | |||
|
|
|||
| if sys.version_info >= (3,): | |||
| class RotatingFileHandler(BaseRotatingHandler): | |||
| terminator = ... # type: str | |||
There was a problem hiding this comment.
Ping, could you remove this?
JelleZijlstra
approved these changes
Mar 25, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
In python3 `RotatingFileHandler` is a subclass of `BaseRotatingHandler` which is a subclass of `FileHandler` which is a subclass of `StreamHandler` which as a `terminator` property but I'm getting a `"RotatingFileHandler" has no attribute "terminator"` error on my code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python3
RotatingFileHandleris a subclass ofBaseRotatingHandlerwhich is a subclass ofFileHandlerwhich is a subclass ofStreamHandlerwhich has aterminatorproperty but I'm getting a"RotatingFileHandler" has no attribute "terminator"error on my code.