Tighten the return type in braintree.PaymentMethod.find() #14916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The possible return types are listed here: https://developer.paypal.com/braintree/docs/reference/response/payment-method/python/ Annoyingly, these classes don't inherit from PaymentMethod, so need to be listed out.
AlexWaygood
changed the title
This comment has been minimized.
This comment has been minimized.
The Braintree docs don't list the complete list of payment types the library can return, the complete list can be found in braintree.payment_method_parser
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The possible return types are listed here:
https://developer.paypal.com/braintree/docs/reference/response/payment-method/python/
Annoyingly, these classes don't inherit from PaymentMethod, so need to be listed out.