Skip to content

Conversation

Spider84pr
Copy link

I have added stub for one function.
This is my first pull request - sorry if something wrong

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented Sep 3, 2025

Looking at the source code, shouldn't this return tuple[Any, ...] (i.e. the normal row type used in SSCursor? And SSDictCursor.SSDictCursor should return dict[str, Any], since it's deriving from DictCursorMixin?

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Sep 4, 2025

Diff from mypy_primer, showing the effect of this PR on open source code:

discord.py (https://github.com/Rapptz/discord.py)
- discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "name", "description"  [misc]
+ discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "description", "name"  [misc]
- discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "name", "description"  [misc]
+ discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "description", "name"  [misc]

@Spider84pr
Copy link
Author

I am very sorry.
While waiting your anwer decided to work on another annotation and added commit in wrong pull request.
Can you help me solve me this problem?
SOrry I am lacking expirience and unaable revert it

@brianschubert
Copy link
Member

Running git revert --no-edit HEAD on the command line should do the trick. That will create a new commit that "undoes" the last commit.

@Spider84pr
Copy link
Author

Running git revert --no-edit HEAD on the command line should do the trick. That will create a new commit that "undoes" the last commit.

THank for advice but I am afraid to do something bad or illegal - I think better wait @srittau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants