-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[tkinter.ttk] Added type annotations for Style
, fix some other incomplete parts
#14348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MarcellPerger1
wants to merge
11
commits into
python:main
Choose a base branch
from
MarcellPerger1:improve-tkinter-ttk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c335867
Fix explicit occurrences of `Incomplete` in tkinter.ttk
MarcellPerger1 508e578
Improve stubs for `setup_master``, `ttk.Style.configure`, `Style.map`
MarcellPerger1 053a00a
Finish types for ttk.Style
MarcellPerger1 f6dd428
Fix unused import
MarcellPerger1 63f8e1e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f63bfb6
Fix pre-commit failures
MarcellPerger1 03981fa
(Try to) Fix CI failures
MarcellPerger1 d3d3beb
Try to fix CI failures again
MarcellPerger1 33f06c8
Fix some more CI failures
MarcellPerger1 fe3f9f6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c86e499
Try to work around stubtest error
MarcellPerger1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda awkward but you could do
*imagespec: *tuple[tkinter._ImageSpec, *tuple[_ImageStatespec, ...]]
. Not sure if this would be problematic to use though for code completion though.