Skip to content

Add type annotations for **options in tkinter.messagebox functions #14341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 30, 2025
Merged

Add type annotations for **options in tkinter.messagebox functions #14341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
878707e
Add explicit `Any` type for `**options` in `tkinter.messagebox` funct…
GameRoMan Jun 26, 2025
623c117
Tkinter type annotations
GameRoMan Jun 27, 2025
20f5793
Merge branch 'main' into patch-2
GameRoMan Jun 27, 2025
45f6380
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 27, 2025
b2c0e27
type annotations for tkinter.messagebox
GameRoMan Jun 27, 2025
7a0c8ec
type annotations for tkinter.messagebox
GameRoMan Jun 27, 2025
41e7e81
revert changes in tkinter.commondialog
GameRoMan Jun 27, 2025
26aa45b
type annotations for tkinter.messagebox
GameRoMan Jun 27, 2025
ed4ccde
Add explicit `Any` for `Dialog.show` return type
GameRoMan Jun 28, 2025
85bd740
type annotations for tkinter.messagebox
GameRoMan Jun 28, 2025
f2de947
type annotations for tkinter.messagebox
GameRoMan Jun 28, 2025
05ddf2e
Update stdlib/tkinter/messagebox.pyi
GameRoMan Jun 29, 2025
532ee85
fix defaults
GameRoMan Jun 29, 2025
70fbb60
Update stdlib/tkinter/messagebox.pyi
GameRoMan Jun 30, 2025
0ce48d2
Update stdlib/tkinter/messagebox.pyi
GameRoMan Jun 30, 2025
7314835
Update stdlib/tkinter/messagebox.pyi
GameRoMan Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/tkinter/commondialog.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ class Dialog:
# sometimes changed to a different type.
options: Mapping[str, Any]
def __init__(self, master: Misc | None = None, **options: Any) -> None: ...
def show(self, **options: Any): ...
def show(self, **options: Any) -> Any: ...
83 changes: 74 additions & 9 deletions stdlib/tkinter/messagebox.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from tkinter import Misc
from tkinter.commondialog import Dialog
from typing import ClassVar, Final
from typing import ClassVar, Final, Literal

__all__ = ["showinfo", "showwarning", "showerror", "askquestion", "askokcancel", "askyesno", "askyesnocancel", "askretrycancel"]

Expand All @@ -23,11 +24,75 @@ NO: Final = "no"
class Message(Dialog):
command: ClassVar[str]

def showinfo(title: str | None = None, message: str | None = None, **options) -> str: ...
def showwarning(title: str | None = None, message: str | None = None, **options) -> str: ...
def showerror(title: str | None = None, message: str | None = None, **options) -> str: ...
def askquestion(title: str | None = None, message: str | None = None, **options) -> str: ...
def askokcancel(title: str | None = None, message: str | None = None, **options) -> bool: ...
def askyesno(title: str | None = None, message: str | None = None, **options) -> bool: ...
def askyesnocancel(title: str | None = None, message: str | None = None, **options) -> bool | None: ...
def askretrycancel(title: str | None = None, message: str | None = None, **options) -> bool: ...
def showinfo(
title: str | None = None,
message: str | None = None,
*,
detail: str = ...,
icon: Literal["error", "info", "question", "warning"] = ...,
default: Literal["ok"] = ...,
parent: Misc = ...,
) -> str: ...
def showwarning(
title: str | None = None,
message: str | None = None,
*,
detail: str = ...,
icon: Literal["error", "info", "question", "warning"] = ...,
default: Literal["ok"] = ...,
parent: Misc = ...,
) -> str: ...
def showerror(
title: str | None = None,
message: str | None = None,
*,
detail: str = ...,
icon: Literal["error", "info", "question", "warning"] = ...,
default: Literal["ok"] = ...,
parent: Misc = ...,
) -> str: ...
def askquestion(
title: str | None = None,
message: str | None = None,
*,
detail: str = ...,
icon: Literal["error", "info", "question", "warning"] = ...,
default: Literal["yes", "no"] = ...,
parent: Misc = ...,
) -> str: ...
def askokcancel(
title: str | None = None,
message: str | None = None,
*,
detail: str = ...,
icon: Literal["error", "info", "question", "warning"] = ...,
default: Literal["ok", "cancel"] = ...,
parent: Misc = ...,
) -> bool: ...
def askyesno(
title: str | None = None,
message: str | None = None,
*,
detail: str = ...,
icon: Literal["error", "info", "question", "warning"] = ...,
default: Literal["yes", "no"] = ...,
parent: Misc = ...,
) -> bool: ...
def askyesnocancel(
title: str | None = None,
message: str | None = None,
*,
detail: str = ...,
icon: Literal["error", "info", "question", "warning"] = ...,
default: Literal["cancel", "yes", "no"] = ...,
parent: Misc = ...,
) -> bool | None: ...
def askretrycancel(
title: str | None = None,
message: str | None = None,
*,
detail: str = ...,
icon: Literal["error", "info", "question", "warning"] = ...,
default: Literal["retry", "cancel"] = ...,
parent: Misc = ...,
) -> bool: ...