Fix incomplete tkinter.commondialog stub
#14340
Conversation
This comment has been minimized.
This comment has been minimized.
| def __init__(self, master=None, **options) -> None: ... | ||
| def show(self, **options): ... | ||
| master: Misc | None | ||
| options: Mapping[str, Any] |
There was a problem hiding this comment.
We now recommend adding a comment for each use of Any. For example:
| options: Mapping[str, Any] | |
| # Types of options are very dynamic. They depend on the command and are | |
| # sometimes changed to a different type. | |
| options: Mapping[str, Any] |
IMO adding just one comment like this is enough for the whole file, since all Any uses are for things named options.
There was a problem hiding this comment.
We now recommend adding a comment for each use of
Any
Separate issue, but it might be worth mentioning this in the CONTRIBUTING.md file or somewhere more visible (or is there already some place with a collection of recommendations like this that I'm just missing?)
There was a problem hiding this comment.
it might be worth mentioning this in the
CONTRIBUTING.mdfile
Hmm, there was a mention, but it was removed as part of #13332. It might make sense to re-add it and perhaps other parts that were more about typeshed policy than style
Co-authored-by: Akuli <akuviljanen17@gmail.com>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| # sometimes changed to a different type. | ||
| options: Mapping[str, Any] | ||
| def __init__(self, master: Misc | None = None, **options: Any) -> None: ... | ||
| def show(self, **options: Any): ... |
There was a problem hiding this comment.
Should the return type of show also be Any or not?
There was a problem hiding this comment.
Yes, I think the return type should be Any. Currently, it is implicitly Any (as it has no return type annotations) but it would probably be better to make is explicit.
(I just forgot to update the return type to Any)
Fixed incomplete
tkinter.commondialogstub.