Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools._distutils._msvccompiler.MSVCCompiler non-None ClassVars #12995

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Nov 11, 2024

The parent class sets these as potentially None. It is never None in this subclass. Fixes issues in pywin32

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pywin32 (https://github.com/mhammond/pywin32)
- setup.py:929:22: error: Unsupported left operand type for + ("None")  [operator]
- setup.py:929:22: note: Left operand is of type "Optional[List[str]]"

@Avasam Avasam merged commit 300204c into python:main Nov 11, 2024
48 checks passed
@Avasam Avasam deleted the setuptools._distutils._msvccompiler.MSVCCompiler-non-None-ClassVars branch November 11, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants