zipfile, threading: Python 3.13 updates
#12081
Conversation
stdlib/zipfile/_path.pyi
Outdated
| @@ -23,6 +23,9 @@ if sys.version_info >= (3, 12): | |||
| @overload | |||
| @classmethod | |||
| def make(cls, source: StrPath | IO[bytes]) -> Self: ... | |||
| if sys.version_info >= (3, 13): | |||
| @classmethod | |||
| def inject(cls, zf: ZipFile) -> ZipFile: ... | |||
There was a problem hiding this comment.
Seems like a public method but missing from the docs
There was a problem hiding this comment.
There was a problem hiding this comment.
It's documented at https://zipp.readthedocs.io/en/latest/history.html#id8, so it does indeed seem like it's meant to be public. (You're right that it should also definitely be documented in the CPython docs as well!)
stdlib/zipfile/__init__.pyi
Outdated
| @@ -206,6 +206,8 @@ class ZipInfo: | |||
| compress_size: int | |||
| file_size: int | |||
| orig_filename: str # undocumented | |||
| if sys.version_info >= (3, 13): | |||
| compress_level: int | None | |||
There was a problem hiding this comment.
>>> import zipfile
>>> zipfile.ZipInfo.from_file("sample.zip").compress_level is None
True
This comment has been minimized.
This comment has been minimized.
aminalaee
changed the title
zipfile: Python 3.13 updateszipfile, threading: Python 3.13 updates
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Sorry for the wait here. This has a bunch of merge conflicts now; I can spend some time tonight resolving the conflicts and getting this ready, unless somebody else is interested in picking it up. |
|
Seems like these changes were already applied in a different PR; after merging in main there's nothing left. Sorry for that! |
No description provided.