Skip to content

Run tests with Python 3.12 - #11544

Merged
srittau merged 6 commits into
python:mainfrom
srittau:py312
Mar 8, 2024
Merged

srittau merged 6 commits into
python:mainfrom
srittau:py312

Conversation

@srittau

@srittau srittau commented Mar 8, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

with:
# TODO: Use Python 3.12. As of 2024-03-08, several third-party
# packages fail to install with Python 3.12.
python-version: "3.10"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably reuse a common workflow for testing stubs, see https://docs.github.com/en/actions/using-workflows/reusing-workflows

@srittau

srittau commented Mar 8, 2024

Copy link
Copy Markdown
Collaborator Author

The primer failure looks unrelated to the Python version to me: https://github.com/python/typeshed/actions/runs/8205495006/job/22442480594?pr=11544#step:5:1109

Maybe some else has an idea? Otherwise I can try downgrading the Python version used for primer as well.

@JelleZijlstra

Copy link
Copy Markdown
Member

The setup.py for confluent-kafka (https://github.com/confluentinc/confluent-kafka-python/blob/v2.1.1/setup.py) does rely on distutils, so maybe something changed there.

@srittau

srittau commented Mar 8, 2024

Copy link
Copy Markdown
Collaborator Author

Makes sense. Distutils is also the reason why stubtest fails for some packages.

@github-actions

github-actions Bot commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
srittau merged commit d424547 into python:main Mar 8, 2024
@srittau
srittau deleted the py312 branch March 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants