Skip to content

Run tests with Python 3.12 #11544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Run tests with Python 3.12 #11544

merged 6 commits into from
Mar 8, 2024

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Mar 8, 2024

No description provided.

@@ -67,6 +67,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
# TODO: Use Python 3.12. As of 2024-03-08, several third-party
# packages fail to install with Python 3.12.
python-version: "3.10"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably reuse a common workflow for testing stubs, see https://docs.github.com/en/actions/using-workflows/reusing-workflows

@srittau
Copy link
Collaborator Author

srittau commented Mar 8, 2024

The primer failure looks unrelated to the Python version to me: https://github.com/python/typeshed/actions/runs/8205495006/job/22442480594?pr=11544#step:5:1109

Maybe some else has an idea? Otherwise I can try downgrading the Python version used for primer as well.

@JelleZijlstra
Copy link
Member

The setup.py for confluent-kafka (https://github.com/confluentinc/confluent-kafka-python/blob/v2.1.1/setup.py) does rely on distutils, so maybe something changed there.

@srittau
Copy link
Collaborator Author

srittau commented Mar 8, 2024

Makes sense. Distutils is also the reason why stubtest fails for some packages.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit d424547 into python:main Mar 8, 2024
@srittau srittau deleted the py312 branch March 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants