Fix patch.object to return a _patch context manager. #1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowillia
force-pushed
the
fix_patch_object
branch
3 times, most recently
from
eb798b9 to
b1fedfc
Compare
This should fix python#914
rowillia
force-pushed
the
fix_patch_object
branch
from
b1fedfc to
1169f9c
Compare
stdlib/3/unittest/mock.pyi
Outdated
| def patch(target: Any, new: Any =..., spec: Any = None, create: Any = False, spec_set: Any = None, autospec: Any = None, new_callable: Any = None, **kwargs: Any) -> Any: ... | ||
| class _patcher: | ||
| def __call__(self, target: Any, new: Any =..., spec: Any = None, create: Any = False, spec_set: Any = None, autospec: Any = None, new_callable: Any = None, **kwargs: Any) -> Any: ... | ||
| def object(self, target: Any, attribute: str, new: Any =..., spec: Any = None, create: Any = False, spec_set: Any = None, autospec: Any = None, new_callable: Any = None, **kwargs: Any) -> _patch: ... |
There was a problem hiding this comment.
You're using = None in some places, and = ... in others.
I generally prefer the latter, but at the very least, it should be consistent within the same file.
There was a problem hiding this comment.
Also, x: t = None really means x: Optional[t] = None, and in modern mypy Optional[Any] is not the same as Any. So beware.
There was a problem hiding this comment.
Thanks for the feedback @matthiaskramm and @gvanrossum ! I wound up using None to be consistent with the other call sites with a similar signature in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #914