Skip to content

Remove hack obsoleted by PEP 655 #11078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Remove hack obsoleted by PEP 655 #11078

merged 5 commits into from
Nov 30, 2023

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Nov 28, 2023

No description provided.

@srittau
Copy link
Collaborator Author

srittau commented Nov 28, 2023

Huh, it seems that while pytype supports NotRequired, it doesn't support Required. I'll invert the TypeDict and try again.

This comment has been minimized.

@srittau
Copy link
Collaborator Author

srittau commented Nov 28, 2023

google/pytype#1535

This comment has been minimized.

This reverts commit 8db02b3.
@srittau srittau added the status: deferred Issue or PR deferred until some precondition is fixed label Nov 28, 2023

This comment has been minimized.

@srittau srittau removed the status: deferred Issue or PR deferred until some precondition is fixed label Nov 30, 2023
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 3a036b6 into python:main Nov 30, 2023
@srittau srittau deleted the pep-655 branch December 1, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants