-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove urllib3 types (not before October 2023) #6898
Comments
They wrote up a nice article about the process too :-) https://sethmlarson.dev/blog/2021-10-18/tests-arent-enough-case-study-after-adding-types-to-urllib3 |
The latest released version of urllib3 (1.26.8) doesn't include the marker yet. I assume that the next major version, which will drop Python 2 support, will include it. Six months after that version's release, we can drop our version of the types. |
Note that the master branch of urllib3 is not what it is currently releasing; the current release doesn't have the types yet. This confused us for a while in #6892. |
As a status update here, the migration plan is documented here: In this, it includes:
The current release is 1.26.11 and includes the warnings: At this time, the following item has not yet occurred:
Current 2.0 progress can be viewed here, and is currently at 86% complete, with at least one open pull request to address dropping older OpenSSL versions: |
2.0.0 was released on Wednesday, April 26, 2023, at 1:20 PM EDT |
We should remember to do #10142 when we do this (it can't be done before, or pyright will start flagging discrepancies between the inline types in |
#6858 added stubs for urllib3. It might have been a mistake, because urllib3 seems to have its own type annotations and even a
py.typed
marker, making the stubs unnecessary.The text was updated successfully, but these errors were encountered: