Skip to content

Conversation

ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Oct 14, 2025

This is a follow-up of:

This bumps aiohttp from 3.11.18 to 3.12.15, using the command:

docker run --rm -v $(pwd):/app -w /app python:3.12 bash -c "
  pip install --upgrade pip &&
  pip install pip-tools &&
  pip-compile --generate-hashes --output-file=requirements.txt --upgrade-package=aiohttp==3.12.15 requirements.in &&
  pip-compile --generate-hashes --output-file=dev-requirements.txt --upgrade-package=aiohttp==3.12.15 --constraint=requirements.txt dev-requirements.in
"

@ezio-melotti ezio-melotti self-assigned this Oct 14, 2025
@ezio-melotti ezio-melotti added the dependencies Pull requests that update a dependency file label Oct 14, 2025
@ezio-melotti ezio-melotti requested a review from hugovk October 15, 2025 16:53
# by the following command:
#
# pip-compile --generate-hashes --output-file=dev-requirements.txt dev-requirements.in
# pip-compile --constraint=requirements.txt --generate-hashes --output-file=dev-requirements.txt dev-requirements.in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using --constraints= here seems like a good idea, because these are installed in the context of those:

release-tools/tox.ini

Lines 10 to 12 in 17c36be

deps =
-r dev-requirements.txt
-r requirements.txt

@sethmlarson What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it I was getting errors (see first commit), and adding it fixed the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants