Reword JavaScript fallback notice to explain trigger without assuming cause#2861
Merged
JacobCoffee merged 4 commits intopython:mainfrom Jan 17, 2026
Merged
Conversation
… cause The “Please turn on JavaScript” notice can be shown even when JavaScript is enabled, e.g. due to intermittent asset loading or caching issues (python#2324, python#2851). This change updates the copy to explain why the notice is shown and to list possible causes without asserting that JavaScript is disabled on the client.
There was a problem hiding this comment.
Pull request overview
This PR updates the JavaScript fallback notice to be more accurate about when and why it's displayed. Instead of assuming JavaScript is disabled, the new message explains that it appears when interactive scripts fail to run, and lists multiple possible causes including disabled/blocked JavaScript or script loading errors.
- Rewrites the fallback notice from "turn JavaScript on" to explain the fallback view is triggered when interactive scripts don't run
- Lists multiple possible causes (disabled/blocked JS, loading errors) rather than assuming JS is off
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
corneliusroemer
commented
Jan 4, 2026
JacobCoffee
approved these changes
Jan 16, 2026
hugovk
reviewed
Jan 17, 2026
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Member
|
thanks for your contribution @corneliusroemer ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The “Please turn on JavaScript” notice can be shown even when JavaScript is enabled, e.g. due to intermittent asset loading or caching issues or when CSS fails to load (#2324, #2851).
This change updates the copy to explain why the notice is shown and to list possible causes without asserting that JavaScript is disabled on the client.
Relates to #2851