fix(frontend): HTML leak in job_detail#2316
Merged
JacobCoffee merged 3 commits intopython:mainfrom Nov 27, 2025
Merged
Conversation
Contributor
Author
|
Wasn't sure whether someone else was still working on this, feel free to close if so. Thanks. |
JacobCoffee
changed the title
job_detail
JacobCoffee
approved these changes
Sep 12, 2024
Member
JacobCoffee
left a comment
JacobCoffee
left a comment
There was a problem hiding this comment.
we can try this, escape didnt work and im unable to get it reproduced as broken in dev
Use `striptags` to strip all html from `og:description`, which was causing HTML to leak. Resolves python#2307
dorian-adams
force-pushed
the
job-detail-leak
branch
from
4cb0725 to
6496599
Compare
Contributor
Author
|
Thanks @JacobCoffee , this is synced now. |
hugovk
reviewed
Nov 26, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
striptagsto strip all html fromog:description, which was causing HTML to leak.Resolves #2307