Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Discussion Template for Adding Terms to Glossary #481

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

rockleona
Copy link
Collaborator

Hi @mattwang44 ,

would you like to have some suggestion toward the template?

@rockleona
Copy link
Collaborator Author

沒有 Preview 可以截圖QQ

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP 我覺得可以先 merge & 啟用,使用上遇到問題再回來修正就好!感謝!

.github/DISSCUSSION_TEMPLATE/add_term.yml Outdated Show resolved Hide resolved
.github/DISSCUSSION_TEMPLATE/add_term.yml Outdated Show resolved Hide resolved
.github/DISSCUSSION_TEMPLATE/add_term.yml Outdated Show resolved Hide resolved
.github/DISSCUSSION_TEMPLATE/add_term.yml Outdated Show resolved Hide resolved
.github/DISSCUSSION_TEMPLATE/add_term.yml Outdated Show resolved Hide resolved
@rockleona
Copy link
Collaborator Author

修正完畢!

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwang44 mattwang44 merged commit a9f07c0 into python:3.11 Jul 18, 2023
1 check passed
cschan1828 pushed a commit to cschan1828/python-docs-zh-tw that referenced this pull request Jul 18, 2023
* Add Discussion Template for Adding Terms to Glosarry

* Fix typo

* Update with reviewer's comment

* update typo
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
* Add Discussion Template for Adding Terms to Glosarry

* Fix typo

* Update with reviewer's comment

* update typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants