Update GitHub Actions testing workflow #94
Conversation
|
This PR needs a review, it looks interesting. (Sadly my front-end skill don't allow me to understand it.) |
|
@pradyunsg would you have time for a review? (I admit I entirely forgot I made this PR...) A |
|
@JulienPalard can we build and publish a test version of CPython's docs with this PR? That might assuage your concerns over the JS. A |
Yes but it will be overwritten by the daily build so I doubt it's a good idea. However a build is available in the "checks" tab as a build artifact, so we can test locally. It is done using the same script as in production so it should be similar. But it builds a 3.9 with a Sphinx 2.4.4, which is probably not very interesting :D I'll try to find the time to do a full build locally, I mean whith multiple Sphinx versions used by the different python versions, to see if there's any compatibility issue, it's easy to do using docsbuild-script and it's |
|
@JulienPalard inspired by a comment from Cam I have taken out all JS changes, which are only strictly necessary for Sphinx 6. A |
| run: > | ||
| python ./docsbuild-scripts/build_docs.py | ||
| --quick | ||
| --build-root ./build_root | ||
| --www-root ./www | ||
| --log-directory ./logs | ||
| --group $(id -g) | ||
| --skip-cache-invalidation | ||
| --theme $(pwd) | ||
| --language en | ||
| --branch 3.11 |
|
Let's merge, this only updates the GitHub Actions workflow file and importantly allows testing feature branches (I want to test some changes before creating a PR), and has three approvals. Thanks! |
Updated remaining jQuery scripts to standard JavaScript, and a few fixes for CSS changes.
I marked various backwards compatability points explicitly -- I don't know what the supported Sphinx versions are for this theme.
A