Repository navigation
Dark theme: "Hide Search Matches" shown on mobile #117
Description
- Using the new dark theme (Dark theme #44) in mobile layout: https://docs.python.org/dev/
- Search for something (e.g. "turtle")
- Click a result
Actual result: "Hide Search Matches" is shown subscript to the right of the search box
Expected result: It's either shown more neatly, or, like desktop view, isn't shown at all:
cc @septatrix
Activity
septatrix commentedon Mar 21, 2023
Okay I found the culprit/fix to restore the previous behaviour (not shown at all). Do we want that or would it actually be desirable to show it?
septatrix commentedon Mar 21, 2023
Given that it is only ever added to either the mobile UI or the desktop UI I feel like it is probably less confusing to suppress it again, aye?
rik commentedon Mar 21, 2023
Besides the UI glitch, I was actually glad to discover this "bug" as I'm not fond of matches being highlighted.
I wish it was available on the wide screen UI too.
septatrix commentedon Mar 22, 2023
The problem is that the toggle is only added to the
#searchboxelement of which there can be only one. So either it would not be visible in one of the two layouts or we would have to do some pretty crazy CSS shenanigans to reuse the same search box in the desktop and mobile layout.hugovk commentedon Mar 25, 2023
You can press esc to remove the highlights.
Yeah, no strong opinion from me, if in doubt let's go for the previous behaviour. Thank you!
hugovk commentedon Apr 11, 2023
@septatrix Would you be able to restore the previous behaviour? For me, this is the only one of the reported issues I'd like fixed before deploying this more widely. And I've heard lots of good feedback about the dark theme!
Remove searchbox id from form (fixes python#117)
septatrix commentedon Apr 12, 2023
Done, #124 restores the previous behaviour