Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished translating using/cmdline.po #899

Merged
merged 8 commits into from
Nov 22, 2019
Merged

Conversation

Seluj78
Copy link
Collaborator

@Seluj78 Seluj78 commented Oct 9, 2019

No description provided.

@Seluj78 Seluj78 added the NEED REVIEWER This PR needs a reviewer :) label Oct 9, 2019
@Seluj78 Seluj78 self-assigned this Oct 9, 2019
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beaucoup de « corrections » qui, lorsqu'on regarde le rendu, sont finalement incorrectes.
Soit on se base sur le fichier .po et on suit la version originale (qui peut comporter des erreurs ou ne pas avoir la même typographie que le français), soit les traducteurs français font l'effort de regarder le rendu (html ou autre) et l'on s'autorise des écarts à la version originale.
Chacun saura où va ma préférence.

@JulienPalard JulienPalard added awaiting changes and removed NEED REVIEWER This PR needs a reviewer :) labels Oct 22, 2019
@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 15, 2019

Je me mets sur une PR upstream

@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 15, 2019

python/cpython#17173

@Seluj78 Seluj78 added NEED REVIEWER This PR needs a reviewer :) and removed awaiting changes labels Nov 15, 2019
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je reviens après un break où il s'est passé beaucoup de choses. Mes remarques à prendre avec des pincettes.

@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 17, 2019

Hmm faut que je mette ca a jour avec les changements upstream... Je regarde ca maintenant

Seluj78 and others added 5 commits November 17, 2019 22:17
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 17, 2019

forced push avec les changements que j'ai fait upstream (cpython)

@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 17, 2019

Besoin d'une dernière review, cc @awecx @deronnax

Co-Authored-By: Mathieu Dupuy <deronnax@users.noreply.github.com>
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
@Seluj78 Seluj78 merged commit f8019cb into python:3.8 Nov 22, 2019
@Seluj78 Seluj78 deleted the using-cmdline branch November 22, 2019 23:41
Seluj78 added a commit that referenced this pull request Nov 22, 2019
@Seluj78 Seluj78 restored the using-cmdline branch November 22, 2019 23:51
@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 22, 2019

J'ai merge alors que la CI n'avais pas run du coup je n'avais pas vu que il manquais un powrap... fait sur master

@Seluj78 Seluj78 deleted the using-cmdline branch February 15, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEED REVIEWER This PR needs a reviewer :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants