Skip to content

FIX: Turtle module constant should not be translated. #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2022
Merged

FIX: Turtle module constant should not be translated. #1901

merged 2 commits into from
Jul 7, 2022

Conversation

JulienPalard
Copy link
Member

Car en fait ça s'utilise à coup de turtle.speed("fastest") donc il faut garder "fastest" dans la doc.

jeanas
jeanas reviewed Jul 5, 2022
View reviewed changes
library/turtle.po Outdated
@@ -934,23 +934,23 @@ msgstr ""

#: library/turtle.rst:617
msgid "\"fastest\": 0"
msgstr "« le plus rapide » : 0"
msgstr "`\"fastest\"` : 0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il ne faut pas des doubles backticks ? Tu veux vraiment utiliser le rôle par défaut ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et toutes les constantes relatives à speed sont à modifier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks fixés.

Quelles autres constantes @christopheNan ?

christopheNan
christopheNan approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est ça. J'avais loupé rapide, lent ..

@PyDocTeur
Copy link

Hello @JulienPalard ! Désolé, mais ton titre de pull request me semble invalide par rapport à ce que je suis programmé d'accepter.
Merci de le corriger ou d'ajouter le label meta si c'est une PR spéciale. Un exemple de titre valide serait : « Traduction de dossier/fichier.po ».

Disclaimer

Je suis un robot fait par l'équipe de l'AFPy et de Traduction
sur leur temps libre. Je risque de dire des bétises. Ne me blâmez pas, blamez les développeurs.

Code source

I'm a bot made by the Translation and AFPy teams on their free
time. I might say or do dumb things sometimes. Don't blame me, blame the developer !

Source code

(state: incorrect_title)
PyDocTeur v1.12.0

@christopheNan christopheNan merged commit c1f223a into python:3.10 Jul 7, 2022
@JulienPalard JulienPalard deleted the mdk-turtle branch July 7, 2022 15:55
JulienPalard added a commit that referenced this pull request Sep 13, 2022
@JulienPalard
FIX: Turtle module constant should not be translated. (#1901)
cfb9615 
* FIX: Turtle module constant should not be translated.

* Oops default roles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanas jeanas jeanas left review comments

@christopheNan christopheNan christopheNan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JulienPalard @PyDocTeur @christopheNan @jeanas