Skip to content

add async_generators benchmark #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2022
Merged

add async_generators benchmark #230

merged 1 commit into from
Sep 6, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Aug 18, 2022 •
edited
Loading 

3.10 -> async_generators: Mean +- std dev: 643 ms +- 28 ms
main -> async_generators: Mean +- std dev: 441 ms +- 20 ms

gvanrossum
gvanrossum approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. @ericsnowcurrently , @mdboom Can one of you approve or merge this?

@ericsnowcurrently ericsnowcurrently merged commit 2082c53 into python:main Sep 6, 2022
@ericsnowcurrently
Copy link
Member

Thanks, @kumaraditya303!

@kumaraditya303 kumaraditya303 deleted the async_generators branch April 7, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @ericsnowcurrently @gvanrossum