Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 8011: Python Governance by Trio of Pythonistas #802

Merged
merged 1 commit into from
Oct 8, 2018
Merged

PEP 8011: Python Governance by Trio of Pythonistas #802

merged 1 commit into from
Oct 8, 2018

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Oct 8, 2018

No description provided.

@vstinner
Copy link
Member

vstinner commented Oct 8, 2018

You can just merge it directly, no? I pushed my PEP 8015 directly using git push :-) I'm not used to PR for new PEPs :-)

@warsaw warsaw self-requested a review October 8, 2018 23:00
@warsaw warsaw merged commit 2e295d9 into python:master Oct 8, 2018
@Mariatta Mariatta deleted the pep-8011 branch October 8, 2018 23:17
@Mariatta
Copy link
Member Author

Mariatta commented Oct 8, 2018

You can just merge it directly, no? I pushed my PEP 8015 directly using git push :-) I'm not used to PR for new PEPs :-)

I think it would be great to always follow the pull request workflow, for several reasons:

  • Have all the CI to work
  • People watching the repo receive notification of the new PR

@vstinner
Copy link
Member

vstinner commented Oct 8, 2018

I think it would be great to always follow the pull request workflow, for several reasons: (...)

Aha, good to know. Will do next time. Sorry, I just have old habits. And for the PEP 8015, I had to rush to push it before the deadline :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warsaw warsaw warsaw approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mariatta @vstinner @warsaw @the-knights-who-say-ni