Skip to content

PEP 791: address PEP review comments #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

PEP 791: address PEP review comments #4430

wants to merge 12 commits into from

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented May 21, 2025 •
edited
Loading

  • add submodule variant
  • add Rationale section
  • expand Motivation
  • rename module, move "Module name" section
  • disband "Open Issues"
  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4430.org.readthedocs.build/pep-0791/

@skirpichev skirpichev force-pushed the pep791-address-comments branch 2 times, most recently from 963f154 to 86e15a2 Compare May 24, 2025 06:34
@skirpichev skirpichev force-pushed the pep791-address-comments branch from 86e15a2 to 8cdce7a Compare May 24, 2025 06:37
@skirpichev skirpichev marked this pull request as ready for review May 24, 2025 06:38
@skirpichev skirpichev requested a review from vstinner as a code owner May 24, 2025 06:38
@skirpichev

This comment was marked as resolved.

Sign in to view
hugovk
hugovk reviewed May 24, 2025
View reviewed changes
skirpichev and others added 3 commits May 24, 2025 11:10
@skirpichev @hugovk
Apply suggestions from code review
58a6938 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@skirpichev
address review: -gcd()
64e2db3
@skirpichev
address review: -02-Jun-2019 in metadata
919f797
@skirpichev

This comment was marked as resolved.

Sign in to view
vstinner
vstinner reviewed May 24, 2025
View reviewed changes
@skirpichev skirpichev mentioned this pull request May 28, 2025
Open
vstinner
vstinner reviewed May 28, 2025
View reviewed changes
zooba
zooba reviewed May 28, 2025
View reviewed changes
@skirpichev skirpichev requested review from vstinner and zooba May 29, 2025 14:49
vstinner
vstinner approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev skirpichev mentioned this pull request Jun 1, 2025
Open
@skirpichev skirpichev force-pushed the pep791-address-comments branch from 177f73b to ae03c4b Compare June 3, 2025 11:05
@skirpichev skirpichev requested a review from vstinner June 3, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk Awaiting requested review from hugovk

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@zooba zooba Awaiting requested review from zooba

@vstinner vstinner Awaiting requested review from vstinner vstinner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skirpichev @vstinner @hugovk @zooba @serhiy-storchaka