-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 769: Add a 'default' keyword argument to 'attrgetter' and 'itemgetter' #4179
Conversation
Hello!
You can use 790 if you like, but we normally pick the next one in sequence, which currently would be 769. Would you prefer to use 769? I've also updated the PR description to include the new PEP checklist, please could you work down it and check them off as appropriate? Thanks! |
Please could you also wrap lines to 79 columns? https://peps.python.org/pep-0012/#general If you have prettier installed, this can do it: prettier --prose-wrap=always --print-width=79 -w filename.rst |
Hello @hugovk ! Thanks for the help and info.
I'm working now in making all linters go green. Thanks again for all the help! |
Linters and builders fixed! |
You're welcome!
Let's go for 769 then. If you make a new branch, you'll need to make a new PR. But the branch name isn't too important and the branch will be deleted after merge, so I'd just keep the current one. |
Cool, thanks! I renamed it to 769, then. Also updated PR title and description. Let me know when this is ready for the discussion in the forum, and I'll open a thread there. Thanks! |
Thanks! There I followed all your suggestions. I'm not 100% sure if the linked sections is fine, Github is not rendering those correctly but I understand that it may be a Github thing not supporting ReST 100% ok. Thanks again! |
Awesome, thanks! There I incorporated those fixes. Thanks for the help! |
Feel free to merge it you're ready. Then open a discussion on https://discuss.python.org/c/peps/19 and open a new PR add the link to the Post-History to the PEP. |
Thank you very much! |
Selected number: 769
This PEP is about adding a
default
keyword argument toattrgetter
anditemgetter
(from theoperator
module`).Thanks!
Basic requirements (all PEP Types)
pep-NNNN.rst
), PR title (PEP 123: <Title of PEP>
) andPEP
headerAuthor
orSponsor
, and formally confirmed their approvalAuthor
,Status
(Draft
),Type
andCreated
headers filled out correctlyPEP-Delegate
,Topic
,Requires
andReplaces
headers completed if appropriate.github/CODEOWNERS
for the PEPStandards Track requirements
Python-Version
set to valid (pre-beta) future Python version, if relevantDiscussions-To
andPost-History
📚 Documentation preview 📚: https://pep-previews--4179.org.readthedocs.build/pep-0769/